# 30 Days of Agile testing, Day 9: Pairing on a code review

**URL:** <https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472>\
**Category:** 30 Days of Testing\
**Tags:** 30-days-of-testing, agile\
**Created:** [7 September 2017 05:41 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472 "2017-09-07T05:41:36Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![heather\_reid](https://sea2.discourse-cdn.com/flex020/user_avatar/club.ministryoftesting.com/heather_reid/32/29_2.png) [@heather\_reid](https://club.ministryoftesting.com/u/heather_reid)\
**Post date:** [7 September 2017 05:41 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472/1 "2017-09-07T05:41:36Z")

</div>

Yes I’m early with this one but I need a bit of advice.

The challenge for Day 9 of [30 days of agile testing](https://dojo.ministryoftesting.com/lessons/30-days-of-agile-testing) is to pair with a developer on a code review.

On testers.chat recently I was advised to do just this but, honestly, it terrifies me! I was previously a developer (developing in MATLAB) but I feel like my current knowledge of programming languages limits me. Maybe it’s imposter syndrome but I’m not sure where to start.

Ahead of Day 9, how can you identify risks in code for a language you’ve never seen before? How do you approach this? Do we need to have these [programming skills](https://blog.gurock.com/top-programming-skills-for-software-testers/)? Or can you participate in a code review without them?

---

<div class="post-metadata">

**Author:** ![g.crawford20](https://avatars.discourse-cdn.com/v4/letter/g/7993a0/32.png) [@g.crawford20](https://club.ministryoftesting.com/u/g.crawford20)\
**Post date:** [7 September 2017 10:26 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472/2 "2017-09-07T10:26:23Z")

</div>

Yes being able to code in the language that is being used would mean you might see issues or risks that would pass you by otherwise but I don’t think that is where most of the value of you being part of the code review comes from.

Your value comes in the questions that you will ask and assumptions you will challenge as you are working through the code changes and the dev explains the workflow through the code.

So yes, you definitely can participate in a code review without being able to code in that language.

---

<div class="post-metadata">

**Author:** ![heather\_reid](https://sea2.discourse-cdn.com/flex020/user_avatar/club.ministryoftesting.com/heather_reid/32/29_2.png) [@heather\_reid](https://club.ministryoftesting.com/u/heather_reid)\
**Post date:** [8 September 2017 13:57 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472/3 "2017-09-08T13:57:32Z")

</div>

A timely post from @lisacrispin on the Dojo about [Pairing With Developers](https://dojo.ministryoftesting.com/lessons/pairing-with-developers-a-guide-for-testers)!

---

<div class="post-metadata">

**Author:** ![lisacrispin](https://sea2.discourse-cdn.com/flex020/user_avatar/club.ministryoftesting.com/lisacrispin/32/556_2.png) [@lisacrispin](https://club.ministryoftesting.com/u/lisacrispin)\
**Post date:** [8 September 2017 15:42 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472/4 "2017-09-08T15:42:16Z")

</div>

My approach is to ask the developer to walk through the code changes with me. If you’re using a tool like GitHub, the process is easy to do. I try to understand the changes/additions and reasoning behind how they were done. I’m basically a glorified rubber duck, but since I do know a lot of design patterns, I can often spot “smells”. When the dev starts explaining it to me, she may also agree it needs fixing. I find it a satisfying activity - we have helped make sure our code is maintainable and robust.

We don’t do that many code reviews since it’s all developed with pair programming, but we do it when we feel there’s a critical change or a fragile part of the code.

Ask questions, developers will enjoy explaining it to you, I promise!

---

<div class="post-metadata">

**Author:** ![heather\_reid](https://sea2.discourse-cdn.com/flex020/user_avatar/club.ministryoftesting.com/heather_reid/32/29_2.png) [@heather\_reid](https://club.ministryoftesting.com/u/heather_reid)\
**Post date:** [18 September 2017 14:53 UTC](https://club.ministryoftesting.com/t/30-days-of-agile-testing-day-9-pairing-on-a-code-review/1472/5 "2017-09-18T14:53:03Z")

</div>

I’m wondering if people had similar issues to @matt on this one?

> **[30 Days of agile testing — Day 9: Pair with a developer during a code review.](https://medium.com/@mattcmf/30-days-of-agile-testing-day-9-pair-with-a-developer-during-a-code-review-baa62e003026)**
>
> For what I expected to be the easiest challenge so far, I actually found this challenge to be the most difficult, but not for the reasons…

> **[30 Days of Agile Testing – Code Review](https://offbeattesting.com/2017/09/09/30-days-of-agile-testing-code-review/)**
>
> by reading the variable and method names I was able to figure out enough of what was going on in the product to ask moderately intelligent questions

> **[30 Days of Agile Testing! Day nine.](https://www.supertestingbros.com/blog/2017/9/10/30-days-of-agile-testing-day-nine)**
>
> Day 9: Pair with a developer on a code review. Can you identify any risks? One of our senior developers, Rodney, was kind enough to let me pair up with him to review a rather large pull request (PR) by another senior developer, Marcus. Look at us,...
