An excellent discussion popped up on the Ministry of Testing Slack recently about pull requests. The person who started the conversation wanted to know.
What is the purpose? What are best practices? Does anyone have some resources to share? Our software department is new to git (moved this year away from Perforce for source control) and our department has varying levels and opinions about pull requests. Needless to say, there’s been some friction surrounding pull requests in the department.
adding suggestions and comments to the pull request. Some very vocal developers are of the opinion that the only comments allowed in pull requests are “blocker” comments like “if you check this in, it will break x”. Suggestion level comments are not welcome in the PR and are detrimental because they slow down the process. Others, including the majority of the test engineering group, are of the opinion that you can add suggestion-level comments as much as you want, just be sure to “approve” the PR if you don’t find any blocker-level issues.
- What, in your experience, is the purpose of a pull request?
- What are some good practices that you’ve seen for them?
- What resources would you share?