A group thread for all feedback regarding the C# course. I’ve found some typos and other nuisances and don’t want to create a new topic each time I find something.
2.4.2 Adding a Framework to a Pipeline
With our code now stored on our machine, we install DotNet Core 18 onto the box so we can run the build process in our pipeline:
Typo: says 18
but should be 8
When pushing the changes I got an error:
! [remote rejected] trunk → trunk (refusing to allow an OAuth App to create or update workflow
.github/workflows/build_test.yml
withoutworkflow
scope)
It took me some time to unravel this mystery but what fixed it was creating a proper token at github.com/settings/tokens
, that is Settings > Developer settings > Personal access tokens > Tokens (classic). I think it would be nice to warn about this in the section where we’re (first potentially creating a new GitHub account) and cloning the repo for the first time.
The suggested GitHub workflow file also requires changes if we’ve followed the course thoroughly, because the test folder was named Test
in the previous lessons, but is referred to as Tests
throughout.
run: dotnet test Timesheet.Tests --filter FullyQualifiedName~Timesheet.Tests.Unit
Thank you for taking the time to share your detailed feedback on the C# course! We really appreciate your attention to detail and the suggestions you’ve made.
I’ve corrected the typo from DotNet Core 18 to 8 in section 2.4.2.
Regarding the GitHub workflow and the OAuth token issue you encountered, it’s great that you were able to troubleshoot it and find a solution. Your idea to include a note about creating a personal access token is a valuable one, and I’ll pass that on to @mwinteringham to consider for future updates.
We’ll also review the inconsistency you mentioned about the test folder naming in the GitHub workflow file.
I’ll DM you shortly to follow up on this. Please feel free to continue posting any other issues you spot here. Your feedback helps us keep improving the course for everyone!
Thanks again for your contributions.
Best,
Sarah
I was really caught off-guard by this assignment. I’m confused by the plural “frameworks” it mentions, especially “frameworks you’ve created”. Are the unit, API and E2E tests we’ve created considered separate frameworks? Or does it refer to participant’s other projects that were created outside of the course? What does “each repository” refer to?
Activity 2.6.2: Write GitHub Readmes for Each Framework
Purpose:
This activity encourages us to think about what we want to share in our documentation and helps us to get into the habit of communicating clearly how our frameworks work.
Steps to take:
Using the list of details and information you feel are important to share, write documentation for each of the frameworks you’ve created. Add it to a README.md file in each repository.
Hey Marek,
To me, the use of “frameworks” in the activity refers to you getting into the habit of documenting in a way that will be useful if you work with any frameworks in the future. Since you’ve only worked on one framework in this course, you can focus on documenting that single framework for now.
@mwinteringham might be able to provide more details or clarification if I’ve got it wrong
Activity 3.1.2 Review Failed Checks
Small thing, the classes in the attached files have namespaces that have different Test
or Tests
nodes.
Also it might not be obvious from the readme that the namespace of the file should reflect the folder structure, as it states that
To start these activities move the test classes within this Zip file into your Timesheet.Test folder
In my opinion, tes. Because the tests and the code they use are isolated from one another we can consider them separate frameworks. They do share the same project / dependency management tool. But in my head keeping them as separate concerns means I can take a holistic approach to my automation. Different frameworks for different concerns.